Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 CI: LLS should only be run if there are Lua file changes #6415

Open
3 tasks done
zach2good opened this issue Nov 7, 2024 · 0 comments
Open
3 tasks done

🔨 CI: LLS should only be run if there are Lua file changes #6415

zach2good opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature request

Comments

@zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Describe the feature

By its very nature, LLS takes a long time to run. We want it to be run when there are Lua changes, but it's a pain in the ass that we have to wait the what, 25 minutes? for it to run when there's a 1-line C++ change etc.

We collect the files changed in a PR, so we could be interrogating that and skipping/auto-passing that job

@zach2good zach2good added the enhancement New feature request label Nov 7, 2024
@zach2good zach2good self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

1 participant