Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composure effect accuracy bonus calculation #6332

Closed
wants to merge 0 commits into from

Conversation

lefneer311
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Updates the scripts/effects/composure.lua to be able to cast the method getMainLevel() for calculating appropriate accuracy bonus, then applies and removes when appropriate.

Closes #6330

Steps to test these changes

Change job to RDM50 or greater
Use !getstats on yourself and note accuracy boost
Use job ability composure
Use !getstats on yourself and note accuracy boost

Your bonus accuracy should be roughly 1/2 of RDM Main level (35 at 70, 45 at 90, etc.)

Xaver-DaRed
Xaver-DaRed previously approved these changes Oct 8, 2024
@Xaver-DaRed Xaver-DaRed added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Oct 8, 2024
@Xaver-DaRed Xaver-DaRed dismissed their stale review October 8, 2024 19:17

Tab usage

@Xaver-DaRed
Copy link
Contributor

Please be sure to read the style guide and apply it to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDM JA Composure Accuracy Buff Value Incorrect
2 participants