🔨 cleanup onEffectGain within items/* files

[MowFord]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Describe the feature

There are two cleanup items that should happen to all item lua files with onEffectGain/onEffectLose functions

• update the mods to be applied directly to the effect
  • This should be done for all effects/* files as well, but want to start here
• remove any instances of onEffectGain for items that don't apply ENCHANTMENT effect, as they are useless and confusing for the uninitiated
  • Example: https://github.com/LandSandBoat/server/blob/base/scripts/items/alchemists_belt.lua
  • This belt applies the imagery effect directly, making the effect functions irrelevant

[MowFord]

a quick and dirty pair of sed commands can do the first item:

• remove all onEffectLose functions: sed -e '/onEffectLose/,/^$/!b' -e 'd' * -i
• replace the target: objects to effect: objects: sed -e '/onEffectGain/,/return itemObject/!b' -e 's/target:/effect:/' * -i

Edit: Also please don't do this until #5726 is merged, lol

I'm good to be assigned this, i just wanted to post it here if someone else wants to take a crack at it