Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set bonuses lost on zone #5741

Closed
3 tasks done
ampitere opened this issue May 15, 2024 · 2 comments · Fixed by #5744
Closed
3 tasks done

🐛 Set bonuses lost on zone #5741

ampitere opened this issue May 15, 2024 · 2 comments · Fixed by #5744
Labels
bug Something isn't working

Comments

@ampitere
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 10

Branch affected by issue

base

Steps to reproduce

  1. !additem 15852
  2. !additem 15853
  3. Equip the rings
  4. Zone

Expected behavior

Set bonuses are retained while zoning.

@ampitere ampitere added the bug Something isn't working label May 15, 2024
@ampitere
Copy link
Contributor Author

ampitere commented May 15, 2024

In my research it does look like CLuaBaseEntity::addGearSetMod is getting called on zoning and the modifier is added but the player's stats are not displaying this.

image
image
image

First is on zone, second is after re-equipping.

@MowFord
Copy link
Contributor

MowFord commented May 15, 2024

change any gear and it seems to fix it

image

after the 2nd zone i removed my feet (kept rings up)

So this is just an issue with the setBonus function not recalculating player hp/mp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants