🐛 Losing !togglegm upon zoning

[Mortalelite]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 10

Branch affected by issue

base

Steps to reproduce

When you have !togglegm and you zone it will be removed. You are able to toggle it back on, but once zone again it is removed. This happens on current char.

If you create a new char it does stay when you zone. If you toggle off !togglegm and zone it comes back on

Expected behavior

Keep !togglegm upon zoning

[Mortalelite]

I found the issue to be within the char_flags.sql

Your current char does not get a flag unless you manually insert a line for it. But if you set gmModeEnable to 1 it stays upon zoning.

If you create a new char and it is marked as a GM, then when you toggle it on. It does stay upon zoning, but once toggle off it stays.

You have go into char_flags and change from 1 to 0 to disable gmModeEndable

[WinterSolstice8]

"manually insert a line" -- can you elaborate further? are there sql errors in map?

[Mortalelite]

If you are in the DB and then go to char_flags and right click to insert row and no errors within map.

[WinterSolstice8]

It sounds like you didn't run the migration?

server/tools/migrations/039_refactor_char_settings.py

Line 61 in 2309bb1

cur.execute("INSERT INTO char_flags (charid) SELECT charid FROM chars ON DUPLICATE KEY UPDATE char_flags.disconnecting = char_flags.disconnecting;");

[Mortalelite]

I ran everything suppose to. But even on a new char when you do !togglegm and turn it off and zone, it auto keeps at 1 instead turning to 0

[WinterSolstice8]

If you had to insert that row that means the migration didn't run, the query above inserts a new row for all pre-existing characters, and new characters get an entry on that table here:

server/src/login/login_helpers.cpp

Line 178 in 2309bb1

if (_sql->Query("INSERT INTO char_flags(charid) VALUES(%u) ON DUPLICATE KEY UPDATE disconnecting = disconnecting", charid) == SQL_ERROR)

[Mortalelite]

Well I would not know how it did run when I updated DB with py -3 dbtool.py update and did all the migration at that time. So how would I run that then.

[Mortalelite]

I ranpy -3 dbtool.py just incase and here what I got

[WinterSolstice8]

hmm... that's really weird. I don't have an explanation for why your char_flags wasn't populated then

[WinterSolstice8]

You should run this query on your db just in case:
INSERT INTO char_flags (charid) SELECT charid FROM chars ON DUPLICATE KEY UPDATE char_flags.disconnecting = char_flags.disconnecting;

[WinterSolstice8]

I think I see the bug. it looks like db.commit() isn't called in the migration, I missed it. Apparently this could mean the query just didn't execute. I tested this on Linux, which may behave differently.

Thanks for the report, you 100% should run the above query.

[Mortalelite]

I ran the query. Just booting back up the server to test it

[Mortalelite]

Ok it is semi working. When you have !togglegm on and turn off before zoning. It comes back on

[WinterSolstice8]

I'll look into it after I get home from work

[Mortalelite]

Ok no worries. Thanks for looking into it. It is something with the gmModeEnable staying as 1 instead going to 0. The gmHiddenEnable is working like it suppose to within char_flags.

[WinterSolstice8]

I did a 5 second check (still on my lunch break)

in charutils::SaveCharGMLevel()
try updating
_sql->Query(Query, "char_flags", "gmModeEnabled =", PChar->m_GMlevel >= 3 ? 1 : 0, PChar->id);
to
_sql->Query(Query, "char_flags", "gmModeEnabled =", PChar->visibleGmLevel >= 3 ? 1 : 0, PChar->id);

[Mortalelite]

Ok that is working

[Mortalelite]

Should I make a PR for this or wait to see if come up with another fix?