Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Spirits Within fails to set ws kill and errors in map log #4584

Closed
3 tasks done
TeoTwawki opened this issue Oct 4, 2023 · 0 comments · Fixed by #4585
Closed
3 tasks done

🐛 Spirits Within fails to set ws kill and errors in map log #4584

TeoTwawki opened this issue Oct 4, 2023 · 0 comments · Fixed by #4585
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TeoTwawki
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows server 2022

Branch affected by issue

base

Steps to reproduce

Use Spirits within, see error in map log

[10/04/23 19:10:47:676][map][error] luautils::onUseWeaponSkill: ./scripts/globals/weaponskills.lua:1012: bad argument #1 to 'lshift' (number expected, got nil)
stack traceback:
[C]: in function 'lshift'
./scripts/globals/weaponskills.lua:1012: in function 'takeWeaponskillDamage'
./scripts/actions/weaponskills/spirits_within.lua:71: in function <./scripts/actions/weaponskills/spirits_within.lua:16> (luautils::OnUseWeaponSkill:3691)

lines 1010 to 1012 of weaponskills global:

-- Pack the weaponskill ID in the top 8 bits of this variable which is utilized
-- in OnMobDeath in luautils.  Max WSID is 255.
defender:setLocalVar('weaponskillHit', bit.lshift(wsResults.wsID, 24) + finaldmg)

line 71 of spirits within:

damage = xi.weaponskills.takeWeaponskillDamage(target, player, {}, primary, attack, calcParams, action)

wsId is missing from the params in the ws script

Expected behavior

See no error, localvar gets set

@TeoTwawki TeoTwawki added bug Something isn't working good first issue Good for newcomers labels Oct 4, 2023
TeoTwawki added a commit to TeoTwawki/LandSandBoat that referenced this issue Oct 5, 2023
TeoTwawki added a commit to TeoTwawki/LandSandBoat that referenced this issue Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant