Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 possible to crash server with an area print inside a trusts onMobDeath script #4583

Open
3 tasks done
TeoTwawki opened this issue Oct 4, 2023 · 1 comment
Open
3 tasks done
Labels
bug Something isn't working

Comments

@TeoTwawki
Copy link
Contributor

TeoTwawki commented Oct 4, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows Server 2022

Branch affected by issue

base

Steps to reproduce

  1. Be ina party of yoruself +1 single trust.
  2. Place a PrintToArea() call in that trusts onMobdeath
  3. dismiss the trust or let it die

Whats happening is after somewhat recent changes the party/alliance is wiped but the print binding still was using it.

During retail accurate trust use this would never happen, so we may opt to simply gracefully fail out instead and then custom death prints just become something you just cannot do.

Expected behavior

Either print the message, or gracefully fail.

@TeoTwawki TeoTwawki added the bug Something isn't working label Oct 4, 2023
@TeoTwawki TeoTwawki self-assigned this Oct 4, 2023
TeoTwawki added a commit to TeoTwawki/LandSandBoat that referenced this issue Oct 5, 2023
We were checking for an alliance even if the players party wasn't in one.

Fixes LandSandBoat#4583
@TeoTwawki
Copy link
Contributor Author

TeoTwawki commented Oct 5, 2023

in my attempt to fix this by adjusting the print function I realized this has further reaching issues than just the one I reported here - the party and alliance are being killed before onMobDeath is finished. That's pretty serious. Previously when alliance didn't exist we'd auto fallback to the party which was why checking alliance ID was safe even when there wasn't one, and checking the party was safe when you were solo because you'd count as a "party of one" but that seems to no longer be the case. My WIP sidesteps the crash, but then I saw tons of other stuff is still broken - better to fix the underlying cause.

@TeoTwawki TeoTwawki removed their assignment Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant