Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worse resource packs compatibility #76

Open
NaiNonTH opened this issue Feb 14, 2023 · 1 comment
Open

Worse resource packs compatibility #76

NaiNonTH opened this issue Feb 14, 2023 · 1 comment

Comments

@NaiNonTH
Copy link

Description & Screenshots

This might be the long-known issue since the very first day of this mod. Let's have a look at the screenshots provided:

2023-02-14_19 50 54

This is the "Better Snow" feature enabled with the Alacrity resource pack loaded.
Apparently, the snow appearing on the grass is only the snow model from vanilla and is inaccurate with the resource pack snow model. This may be similar to the Mycelium issue...

2023-02-14_19 54 22

This is the grass block model with the "Better Grass" enabled and the Foliage+ Tweaks resource pack loaded, which is made by me, NaiNonTheN00b1.
As you can see, the texture on the grass patch model looks broken. But not on all of them though — only certain of them that face out. This grass patch is applied on the grass block via multipart Blockstates.

2023-02-14_19 54 54

Here's the last one. this is the "Better Grass" feature, set to fancy, with the Foliage+ resource pack loaded, which is also made by me. The part where it is supposed to be a dirt texture turns out transparent.

These issues do not only occur on resource packs specified; other resource packs that contain their own grass block model also lead to this issue.

@LambdAurora
Copy link
Owner

image
Next release will try to fix the issues with resource packs adding stuff on top of the grass blocks.

For Foliage+ I am not sure what I can even do, the model is... not very workable with LambdaBetterGrass, at this point having a variant or extension of that pack that restores the vanilla model and use LambdaBetterGrass' resource pack APIs to reproduce the same effects would work much better.

And for the better snow stuff, the mod is using its own model because the Vanilla model has much more aggressive side culling that can results in quite terrible results when used with the mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants