Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀♻️⚡️ rewrite api-store #2921

Merged
merged 74 commits into from
Mar 10, 2024
Merged

🔀♻️⚡️ rewrite api-store #2921

merged 74 commits into from
Mar 10, 2024

Conversation

jxn-30
Copy link
Member

@jxn-30 jxn-30 commented Feb 27, 2024 •
edited
Loading

What kind of update does this PR provide? Please check

  • new translations / updated translations / translation fixes
  • a new feature
  • a new module
  • a bugfix for an existing feature / module
  • improvement of style or user experience
  • other: Performance update, code refactoring

What is included in your update?

  • a complete rewrite of the api-store
    • This migrates the store from an Options-Store to a Setup-Store (different form of writing)
    • This improves performance as heavy computed properties are now fake-computed (such as vehicle and building lookup dictionaries)
    • This also improves maintainability
  • A TypedWorker class to create sharedWorker with Typescript support
  • A LSSMStorage class to improve Storing values of LSSM in a new, organized, indexedDB
    • currently, it is only used to cache missionTypes but will be used to store settings etc. in there later

Additional notes
Migration done, few bugfixes are still to be done, soon ready for review

jxn-30 added 27 commits February 9, 2024 00:55
@jxn-30
🚧 [workers] add a TypedWorker class for shared workers
f1da374
@jxn-30
🚧 [workers] experiment with workers
095f14b
@jxn-30
🚧 [workers] create a working typed API-fetch worker
e01a9b1
@jxn-30
🚧 [workers] vehicles API can be stored and fetched
b1e2994
@jxn-30
🚧 [workers] add a worker to compute vehicles fake-computeds
d3c7050
@jxn-30
🚧 [rewriteApiStore] update vehicles from radioMessage
4545d90
@jxn-30
🚧 [rewriteApiStore] add fetching buildings API
2efc06d
@jxn-30
🚧 [rewriteApiStore] add updating building on buildingMarkerAdd
c8f4b72
@jxn-30
🚧 [rewriteApiStore] add fetching a single vehicle
06994b4
@jxn-30
🚧 [rewriteApiStore] add fetching a single building
8327518
@jxn-30
🚧 [rewriteApiStore] add missions
06bc06a
@jxn-30
🚧 [rewriteApiStore] migrate missions to new store
4e74956
@jxn-30
🚧 [rewriteApiStore] add participatedMissions
4cb2021
@jxn-30
Merge branch 'dev' into rewrite-apistore
07e10ac
@jxn-30
🚧 [rewriteApiStore] rename missionTypesArray getter
7a774cd
@jxn-30
🚧 [rewriteApiStore] store missions in a new indexedDB
2962651
@jxn-30
🚧 [rewriteApiStore] add allianceinfo API endpoint
4d2ce5f
@jxn-30
🚧 [rewriteApiStore] autoupdate
537c9f0
@jxn-30
🚧 [rewriteApiStore] add credits API
89253c8
@jxn-30
🚧 [rewriteApiStore] fix congruent requests to same worker
17adf8b
@jxn-30
🚧 [rewriteApiStore] fix worker param passing
bce034b
@jxn-30
🚧 [rewriteApiStore] store api results in worker for caching purposes
221e1c1
@jxn-30
🚧 [rewriteApiStore] remove missions from broadcast
599897b
@jxn-30
🚧 [rewriteApiStore] add settings API
fbb508e
@jxn-30
🚧 [rewriteAPIStore] migrate request method
60e52a9
@jxn-30
🚧 [rewriteAPIStore] make telemetry await fetching secret key
02564df
@jxn-30
Merge branch 'dev' into rewrite-apistore
3cad9da 
# Conflicts:
#	src/modules/extendedCallList/assets/sort/mission.ts
@jxn-30 jxn-30 added the enhancement New feature or request label Feb 27, 2024
@jxn-30 jxn-30 self-assigned this Feb 27, 2024
@jxn-30
Copy link
Member Author

jxn-30 commented Feb 27, 2024

@LSS-Manager deploy

@jxn-30
Copy link
Member Author

jxn-30 commented Mar 5, 2024

@LSS-Manager deploy

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

👍️ I have successfully deployed a build 4.7.12+20240305.2136 on pr2921!

@jxn-30
Copy link
Member Author

jxn-30 commented Mar 6, 2024

@LSS-Manager deploy

@jxn-30 jxn-30 marked this pull request as ready for review March 6, 2024 10:14
@jxn-30 jxn-30 requested a review from Cr4zyc4k3 March 6, 2024 10:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

👍️ I have successfully deployed a build 4.7.12+20240306.1115 on pr2921!

@jxn-30
Copy link
Member Author

jxn-30 commented Mar 6, 2024

@LSS-Manager deploy

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

👍️ I have successfully deployed a build 4.7.12+20240306.2215 on pr2921!

@jxn-30
Copy link
Member Author

jxn-30 commented Mar 7, 2024

@LSS-Manager deploy

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

👍️ I have successfully deployed a build 4.7.12+20240307.1142 on pr2921!

Cr4zyc4k3
Cr4zyc4k3 requested changes Mar 7, 2024
View reviewed changes
src/workers/stores/api/missionTypes.worker.ts Show resolved Hide resolved
typings/Ingame.d.ts Show resolved Hide resolved
typings/modules/LSSMAQL/LSSMAQL.d.ts Show resolved Hide resolved
src/workers/stores/api/vehicles.worker.ts Show resolved Hide resolved
src/workers/stores/api/fetchApi.worker.ts Outdated Show resolved Hide resolved
src/mainpageCore.ts Show resolved Hide resolved
src/modules/extendedBuilding/assets/dispatchCenterBuildingFilter.ts Show resolved Hide resolved
src/modules/extendedCallList/assets/vehicleMissionParticipationState.ts Show resolved Hide resolved
src/modules/redesign/components/assets/einsatz.vue Show resolved Hide resolved
src/modules/redesign/types/components/vehicle.d.ts Show resolved Hide resolved
@jxn-30
Copy link
Member Author

jxn-30 commented Mar 8, 2024

@LSS-Manager deploy

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

👍️ I have successfully deployed a build 4.7.12+20240308.2146 on pr2921!

@jxn-30 jxn-30 requested a review from Cr4zyc4k3 March 9, 2024 22:43
@jxn-30 jxn-30 merged commit 1f700af into dev Mar 10, 2024
8 checks passed
@jxn-30 jxn-30 deleted the rewrite-apistore branch March 10, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cr4zyc4k3 Cr4zyc4k3 Cr4zyc4k3 approved these changes

Assignees

@jxn-30 jxn-30

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxn-30 @Cr4zyc4k3