Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐🇵🇹 [core] main pt_PT translation #2573

Merged
merged 25 commits into from
Sep 18, 2023
Merged

🌐🇵🇹 [core] main pt_PT translation #2573

merged 25 commits into from
Sep 18, 2023

Conversation

Naqui23
Copy link
Contributor

@Naqui23 Naqui23 commented Aug 30, 2023 •
edited
Loading

🌐 [core] version pt_PT

What kind of update does this PR provide? Please check

  • new translations / updated translations / translation fixes
  • a new feature
  • a new module
  • a bugfix for an existing feature / module
  • improvement of style or user experience
  • other: Please fill out

Which language(s) did you add/update translations for?
use the xx_XX notation for exact language!

  • pt_PT
  • yy_YY
  • ...

What is included in your update?

  • new translations for xyz
  • updated translations for abc
  • fixed bug foo
  • ...

Additional notes
Please add any further notes here!

@Naqui23
Create pt_PT
5ba7e95 
🌐 [core] version pt_PT
@Naqui23 Naqui23 closed this Aug 30, 2023
@Naqui23 Naqui23 reopened this Aug 30, 2023
@jxn-30 jxn-30 changed the title Create pt_PT 🌐 [core] main pt_PT translation Aug 30, 2023
jxn-30
jxn-30 requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@jxn-30 jxn-30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide minimum the files buildings.ts, global.ts, schoolings.ts and vehicles.ts in a pt_PT folder, otherwise, LSSM will not work.

src/i18n/pt_PT Outdated Show resolved Hide resolved
@Cr4zyc4k3
Copy link
Collaborator

@Naqui23 Is this branch ready for merge or work in progress?

@Cr4zyc4k3 Cr4zyc4k3 added the i18n This issue is related to i18n and locales label Aug 31, 2023
@jxn-30
Copy link
Member

jxn-30 commented Aug 31, 2023

Please also provide minimum the files buildings.ts, global.ts, schoolings.ts and vehicles.ts in a pt_PT folder, otherwise, LSSM will not work.

Now only the correct content is missing. You can find help for that in our Contribution Guideline and we can also help on our Discord Server. We do know that this is much work but as said: LSSM won't work without them, as it relies on them (and the game unfortunately doesn't provide these information in a good way so they need to be written down manually).

@Cr4zyc4k3 Cr4zyc4k3 marked this pull request as draft August 31, 2023 19:58
@Cr4zyc4k3 Cr4zyc4k3 added enhancement New feature or request good first issue Good for newcomers LSSM-API Related to all changes to the LSSM-API labels Aug 31, 2023
@Naqui23
Copy link
Contributor Author

Naqui23 commented Aug 31, 2023

@Naqui23 Is this branch ready for merge or work in progress?

is a work in progress

@Naqui23 Naqui23 marked this pull request as ready for review September 1, 2023 17:50
Cr4zyc4k3
Cr4zyc4k3 requested changes Sep 2, 2023
View reviewed changes
static/lssm-v4.user.js Outdated Show resolved Hide resolved
@Cr4zyc4k3 Cr4zyc4k3 requested a review from jxn-30 September 13, 2023 08:26
@Cr4zyc4k3 Cr4zyc4k3 changed the title 🌐 [core] main pt_PT translation 🌐🇵🇹 [core] main pt_PT translation Sep 13, 2023
@Suchty112
Copy link
Member

@LSS-Manager deploy

@Suchty112 Suchty112 self-requested a review September 18, 2023 18:52
@github-actions
Copy link

👍️ I have successfully deployed a build 4.7.8+20230918.2050 on pr2573!

Suchty112
Suchty112 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Suchty112 Suchty112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joa, I have adjusted it so far.
At least it is displayed in the game. the rest is not really usable at the moment.
🤷🏻‍♂️

@Suchty112 Suchty112 merged commit 700b301 into LSS-Manager:dev Sep 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cr4zyc4k3 Cr4zyc4k3 Cr4zyc4k3 approved these changes

@jxn-30 jxn-30 jxn-30 approved these changes

@Suchty112 Suchty112 Suchty112 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers i18n This issue is related to i18n and locales LSSM-API Related to all changes to the LSSM-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naqui23 @Cr4zyc4k3 @jxn-30 @Suchty112