Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container release #2

Open
phoenix-bjoern opened this issue Sep 13, 2024 · 6 comments
Open

Container release #2

phoenix-bjoern opened this issue Sep 13, 2024 · 6 comments

Comments

@phoenix-bjoern
Copy link

First of all: Thank you very much for open sourcing this useful tool! I guess many admins very much appreciate this big step :-)

Linbit SDS is often used in a container context (e.g. Kubernetes). Therefore it would be useful if you could publish container images on every release. The Makefile already contains the necessary build step, probably only the GH action is missing to execute and publish the images on a new release. I would propose to use the existing Quay account (https://quay.io/organization/linbit).

@rck
Copy link
Member

rck commented Sep 13, 2024

the gui is just a bunch of java script that, if put into the right location, is served by the linstor-controller. So IMO the controller/linstor images would be the correct location to install the linstor-gui package

@phoenix-bjoern
Copy link
Author

@rck I disagree. The GUI is a web application. The proper approach to host it in K8S is to have an ingress (domain, SSL, authentication), a service and a deployment (resource control/limits). The requirements for running the GUI is completely different from running the controller in K8S. Sure you can run the controller and the GUI image side-by-side in the same namespace, but maybe you also want to run it in a different cluster and just allow communication with the controller.
So, IMHO having a container release of the GUI is a must have. Please don't mix it up with the Linstor controller.

@Liang0028
Copy link
Collaborator

An experimental Docker deployment solution has been implemented and merged 65df173 into the main branch. If you're interested, we encourage you to test it out.

@cduchenoy
Copy link

Hi,

First of all: Thank you very much for open sourcing linstor-gui

Your experimental Docker deployment solution works as expected 👍

We have submitted some improvements to you including native https support see pr #7

@Liang0028
Copy link
Collaborator

Hi,

First of all: Thank you very much for open sourcing linstor-gui

Your experimental Docker deployment solution works as expected 👍

We have submitted some improvements to you including native https support see pr #7

Thank you very much. However, our release process has not yet been migrated to GitHub, so we may need to address that first. I will discuss this proposal with the relevant people. Thanks again!

@boedy
Copy link

boedy commented Oct 13, 2024

Having https://hub.docker.com/u/linbit as a verified trusted source to pull from would also be a good option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants