adding max prover config, and separate wasm instances #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
jimthematrix
requested changes
Sep 30, 2024
| sp.proverCacheRWLock.RLock() | ||
| circuit, _ := sp.circuitsCache.Get(workerID) | ||
| provingKey, _ := sp.provingKeysCache.Get(workerID) | ||
| sp.proverCacheRWLock.RUnlock() // release the lock, happy path, 1 lock is good enough |
There was a problem hiding this comment.
if this is moved down to after the if block, it should be equivalent but without the re-locking right?
There was a problem hiding this comment.
the code here is for upgrading the read lock to a write lock if the prover has not been cached.
there is no lock upgrading built-in, so there could always be a race condition between releasing the read lock and obtaining the write lock, which means another check is always required.
jimthematrix
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #226
Update the golang client to follow the pattern used in this zeto test: hyperledger-labs/zeto#87 to ensure concurrent proof generation are performance on different wasm instances to avoid concurrent modification of shared memory in a single wasm instance.