Fixing issue with automated ride hail getting simulations stuck #3766
Conversation
…tly just to open the PR)
…-stuck-parallelism # Conflicts: # src/test/scala/beam/agentsim/agents/ElectricVehicleChargingBehaviorTest.scala
|
There is another test related to electric vehicles, This one does not have any ride hail vehicles. I am investigating whether the issue is the same with AV RH and this one. |
…ecified classes. The default was kept as 60s.
|
Investigation led to the conclusion that stuck finder was killing agents that were not actually stuck. I have doubled Beamville's stuckAgentDetection timeout from 20s to 40s to specified classes, the default was kept as 60s as a first guess of the timeout needed. I'll be performing tests and updating this value if needed. A new issue #3798 was created related to these findings. |
|
test! Doubling the stuckfinder timeout seems to not be enough for it to not get stuck on CI. |
Modifies stuck finder code to log the maximum timeout observed on CI.
|
test! |
fixes compile issue
|
test! Got stuck on ChargingSpec |
…ve the logs and see if ChargingSpec will pass.
|
test! |
1 similar comment
|
test! |
|
test! Did not get stuck on CI but somehow failed unrelated tests: beam.agentsim.agents.RideHailAgentSpec.A RideHailAgent should drive around when I tell him to |
|
test! ElectricVehicleChargingBehaviorTest got stuck as usual. |
…eously. Testing showed this could be a source of locking as well.
|
test! |
There is an issue with AV RH which was discovered on GEMINI but later was proven to happen on develop as well, although less frequently.
The test "Ride Hail Electric vehicles" should "pick chargers choosing smaller DrivingTimeCost." of
ElectricVehicleChargingBehaviorTestsometimes gets stuck on CI. Investigation led to the conclusion that, at least for this particular test, the issue only appears when running multiple beam simulations in parallel (which is the case for CI).This change is