Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into Release-plz #395

Open
alexsnaps opened this issue Nov 26, 2024 · 0 comments
Open

Look into Release-plz #395

alexsnaps opened this issue Nov 26, 2024 · 0 comments
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@alexsnaps
Copy link
Member

alexsnaps commented Nov 26, 2024

Automate releases

Release-plz could help us releasing using merging.
There is a catch as we need a crate published and a server image pushed, but @adam-cattermole looked into it a bit and it should be feasible. Question is can we release the server w/o needing a crate pushed to crates.io?

Our server's build.rs

That would probably need to change. Mostly around the versioning being directly retrieved from Cargo.toml. We probably need to swap that out for a LIMITADOR_VERSION, that'd be set in our build.rs just as we do for the others.

That would need to check whether we're building from a git local repo (which doesn't happen always, e.g. if someone would be able to build and install through crates.io - tho not a thing as of now). If so, check if git tag --points-at HEAD points to a tag that matches v{CARGO_PKG_VERSION}. If so that's the version, otherwise it's v{CARGO_PKG_VERSION}-dev; as with Release-plz main would have CARGO_PKG_VERSION pointing to the next version to be released. We'd "just" would need to make sure this is tagged before building tho...

@alexsnaps alexsnaps added the github_actions Pull requests that update GitHub Actions code label Nov 26, 2024
@alexsnaps alexsnaps moved this to Todo in Kuadrant Nov 26, 2024
@alexsnaps alexsnaps added this to the Limitador Server v2.0.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
Status: Todo
Development

No branches or pull requests

1 participant