Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom RAG configuration not respected for retrievers #69

Open
loiccordone opened this issue Oct 16, 2024 · 7 comments
Open

Custom RAG configuration not respected for retrievers #69

loiccordone opened this issue Oct 16, 2024 · 7 comments

Comments

@loiccordone
Copy link

Hello!
Thanks for RAGbuilder, it's a very nice project.

I am using the custom RAG configuration, but even if I explicitly mention that I only want to use "Vector DB - Similarity Search" as a retriever, in most of the runs it uses "Vector DB - MMR search" and/or "BM25 Search".

image
image

I don't have access to MMR search or BM25 with my vector DB (Azure CosmosDB for NoSQL), that's why I only want to use Similarity Search.
I'm using Bayesian optimization, but it also happened with "Run all combinations". Am I doing something wrong or is there a bug? I pulled the latest 0.20.0 image and same issue.

Thank you!

@aravind10x
Copy link
Contributor

Hi @loiccordone, thanks for reporting this - this is a bug. We will ship a patch today itself.

@loiccordone
Copy link
Author

Hi @aravind10x, any news on this issue? Thank you!

@aravind10x
Copy link
Contributor

Hi @loiccordone , yes, shipping the fix with this PR. Will publish as a new release shortly.

One thing to note: currently the BM25 retriever implementation is not vector database dependent. (See BM25 retriever in langchain). So perhaps, you don't need to unselect it even if your vector DB (Azure CosmosDB for NoSQL) doesn't support it.

Once again, thanks for flagging this issue! Truly appreciate it! Please reach out if you run into any other issues or challenges with your RAG optimization.

@loiccordone
Copy link
Author

Hi @aravind10x, I am still encountering issues with 0.0.22. It now seems that it's not iterating through the selected retrievers? Even selecting the same retriever twice:
image

In this run, I've selected "Vector DB - Similarity Search", "Multi Query Retriever" and "Parent Doc Retriever - Full doc", but only "Vector DB - Similarity Search" (often doubled) appeared in the 50 runs (with Bayesian optimization)

Thank you

@aravind10x
Copy link
Contributor

@loiccordone So sorry that this is still an issue - let me try to reproduce and fix this right away. Will confirm back once done.

@aravind10x
Copy link
Contributor

aravind10x commented Nov 5, 2024

@loiccordone - this is fixed now. Sorry about the sneaky bug! Updated the fix in repo. However the fix is not available yet in pypi or docker. Will let you know once we have it there

@aravind10x
Copy link
Contributor

Hi @loiccordone - did you get a chance to test this? Please let us know if you run into any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants