Botania expansion #420
Botania expansion #420
Conversation
now spawns particle only when there is overheat
This reverts commit 44d4eee.
|
I almost forgot: i got one flower that is pre made, but it wasn't quite needed. I can add it to modpack but keep it commented (so it won't impact gameplay for now) |
| server.commandManager.executeCommandSilent(server, '/summon minecraft:lightning_bolt '~pos.x~' '~pos.y~' '~pos.z ); | ||
| subtile.setCustomData({charge: 0}); | ||
| } else{ | ||
| server.commandManager.executeCommandSilent(server, "/particle magicCrit "~pos.x~" "~(1.2f + pos.y)~" "~pos.z~" .4 .4 .4 0 5"); |
There was a problem hiding this comment.
try to replace commands with native access:
you can get an instance of World via .native, for example world.native where world is IWorld from ZenScript
There was a problem hiding this comment.
Just be careful with spawnParticle since it could be clientonly call.
There was a problem hiding this comment.
Yes, spawnParticle was client side only
| botania.page.campanimia0=§1坎帕尼米亚§r 是一种喜欢吸收 thaumaturge 提炼器中剩余精华的花。留下的精华种类越多，它生成的 §4魔力§r 就越多。<br>请注意，提炼器必须正常工作——需要同时提供热量和水。 | ||
| botania.page.campanimia1=&o别喝得太醉哦&r | ||
|
|
||
| tile.botania:flower.nuclianthus.name=纽克莲花 |
There was a problem hiding this comment.
| tile.botania:flower.nuclianthus.name=纽克莲花 | |
| tile.botania:flower.nuclianthus.name=核辐莲 |
All zh_cn localization for flower names seem be using transliteration and barely contains useful information. I guess this is bacause these names are artificial. Please provide what these names are made up of, or it might confuse translators a lot.
There was a problem hiding this comment.
Here are the names of flowers name reference:
Amuileria kaerunea (Aquilegia caerulea + Kaminari[thunder])
Antirrhift (Antirrhinum + Shift)
Echinacenko (Echinacea + kenko[health])
Jikanacea (Echinacea + jikan[time])
Rokku Eryngium (Eryngium + Rokku)
Campanimia (Campanula + alkimia)
Nuclianthus (Helianthus + nuclear)
| 'item.nuclearcraft.fuel_thorium.tbu_ox': [14400, 40, 125], // TBU-OX | ||
| 'item.nuclearcraft.fuel_thorium.tbu_ni': [18000, 32, 125], // TBU-NI | ||
| 'item.nuclearcraft.fuel_thorium.tbu_za': [11520, 50, 125], // TBU-ZA |
There was a problem hiding this comment.
Having this type of pedefined values will make a "correcting bomb", when I will need to remember every place in code to correct values if NC configs is changed.
It will be even worst since NC is going to be updated soon, so configuration and default values may change.
Please, check out if NC allowing to have native getters. Maybe you could just call a function like native.nuclearcraft.fuels.getEfficiency() or something like that.
| return aspects; | ||
| } | ||
|
|
||
| function drinkEssentia(world as IWorld, cruciblesPosList as IBlockPos[]) as void { |
There was a problem hiding this comment.
Please make this tests:
- Place and configure 20 flowers of each added type
- Automate them to work continiously
- Create Spark Profile
- Send profile to comment here
I want to see if all flower functions are performant enough, because some functions sounds kinda sus.
There was a problem hiding this comment.
https://spark.lucko.me/Yy75xxy6f6
I'm not sure if this is what was needed
There was a problem hiding this comment.
Yes, this is what i need.
Profile shows that Antirrhift is causing small lag. Its notable, but not terrible. If you can optimize it - would be good.
As you can see on the call stack, block nbt get/set is what causing most of CPU strain. Possible solution would be delay updates OR some high-skill native manipulations, like directly changing TileEntity class properties, omitting working with NBT.
| static recipesLigthningFlower as IItemStack[string] = { | ||
| 'item.appliedenergistics2.material.certus_quartz_crystal': <item:appliedenergistics2:material:1>, | ||
| 'item.appliedenergistics2.material.purified_certus_quartz_crystal': <item:appliedenergistics2:material:1>, | ||
| 'item.appliedenergistics2.material.certus_quartz_crystal_charged': <item:appliedenergistics2:material:1>, | ||
| } as IItemStack[string]; |
There was a problem hiding this comment.
Please add this recipes at least into crafting hints by scripts.jei.crafting_hints.add1to1().
I dont know how to do that, but i think you need some kind of a trick to have recipe list available from both places - #loader contenttweaker and default loader. Ask me if you will not be able to find solution.
There was a problem hiding this comment.
Same as ZenUtils LateSetCoTFunction, RandomTweaker custom botania flowers also support it.
<cotSubTile:name>
scripts/mods/botania.zs
Outdated
| mods.botania.Apothecary.addRecipe(<botania:specialflower>.withTag({type: "jikanacea"}), [ | ||
| <astralsorcery:itemtunedcelestialcrystal>.withTag({astralsorcery: {constellationName: "astralsorcery.constellation.horologium", crystalProperties: {collectiveCapability: 100, size: 900, fract: 0, purity: 100}}}), | ||
| <botania:rune:14>, | ||
| <botania:rune:9>, | ||
| <quark:rune:2>, | ||
| <quark:rune:4>, | ||
| <quark:rune:4>, | ||
| <thaumicaugmentation:material:5>, | ||
| ]); |
There was a problem hiding this comment.
I dont like this recipe.
- Horologrium is too grindy and boring ingredient to make, especially considering it require lot of boring processes like waiting 28 days. Replace this ingredient to something common and widely used. It may be related to AS as well
- I dont know, maybe its my personal feeling, but i have picking exact color for most of botania recipe, like picking petal colors. Its sounds repetative. I would ask here to replace exact colored runes to wildcarded ones, accepting any rune color. This is related to other recipes as well. But you can insist to keep colored runes, i dont mind.
There was a problem hiding this comment.
1.Replaced crystal with resonating gem
2. Personally i think that crafting recipe or runes is awesome but never used in actual progress. We even have rainbow rune that is combination of all 8 craftable runes, I just feel it's kinda wasted crafting ingredient. I'm willing to replace all runes with petal to match classic botania petals
|
Magiculture Integrations mod adding new flower, maybe this would be interesting for you
|
New 7 flower!
Antirrhift [functional flower] - flower that speeds up mana transportation for the cost of 20% tax
Amuileria kaerunea [functional flower] - crafting with lightning
Echinacenko [functional flower] - provides nutritients to player
Jikaneesia [functional flower] - extends the effect of time in a bottle
Rokku Eryngium [functional flower] - flower that cuts astral rock crystals
Refreshed Botania questbook
Technical info:
/gamerule logAdminCommands falseto prevent log spam when using Nuclianthus (as you can see there was one reverted change - if you want to keep commands log i suggest using the version that prevents console spam)