Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key normalization broke Plots backend #317

Open
BeastyBlacksmith opened this issue May 13, 2023 · 1 comment
Open

Key normalization broke Plots backend #317

BeastyBlacksmith opened this issue May 13, 2023 · 1 comment

Comments

@BeastyBlacksmith
Copy link
Contributor

885888e broke the possibility to nest Options like in

Options(Options("solid" => nothing) => nothing, "draw opacity" => 1.0)

I can fix that in the next Plots release by using

merge(Options("solid" => nothing), Options("draw opacity" => 1,0))

but technically I would also need to retro-cap the older versions.

@tpapp
Copy link
Collaborator

tpapp commented May 13, 2023

I think that the first version ever worked was an overlooked corner case, the recommended API is merge (and always has been, for a given value of always).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants