Add persistent Collection builder functions #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Goooler
force-pushed
the
add-build-extensions
branch
from
fe58e7d
to
bc52615
Compare
qurbonzoda
requested changes
Jan 4, 2024
Goooler
force-pushed
the
add-build-extensions
branch
from
bc52615
to
20ad7a1
Compare
qurbonzoda
reviewed
Jan 5, 2024
Comment on lines
+774
to
+779
| * The list passed as a receiver to the [builderAction] is valid only inside that function. | ||
| * Using it outside the function produces an unspecified behavior. |
There was a problem hiding this comment.
Builders in kotlinx.collections.immutable are capable of constructing a new persistent collection multiple times. However, I'm struggling to identify a compelling use case for retaining a reference to the builder and utilizing it outside the builderAction. If we constraint the builder to be valid only within the function, could using a MutableList as the receiver be a more performance-efficient choice?
Goooler
force-pushed
the
add-build-extensions
branch
2 times, most recently
from
62dfb51
to
c90d590
Compare
Goooler
force-pushed
the
add-build-extensions
branch
from
c90d590
to
1ac235e
Compare
Goooler
commented
Feb 27, 2024
Comment on lines
+781
to
+785
| @OptIn(ExperimentalTypeInference::class, ExperimentalContracts::class) | ||
| public inline fun <T> buildPersistentList(@BuilderInference builderAction: PersistentList.Builder<T>.() -> Unit): PersistentList<T> { | ||
| contract { callsInPlace(builderAction, InvocationKind.EXACTLY_ONCE) } | ||
| return persistentListOf<T>().builder().apply(builderAction).build() | ||
| } |
There was a problem hiding this comment.
- Annotate
@BuilderInferencefor better generic type support. - Add
InvocationKind.EXACTLY_ONCEcontract to indicate the function parameter will be invoked exactly one time.
Goooler
force-pushed
the
add-build-extensions
branch
from
1ac235e
to
f4b5f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137.