Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up samples to make them more kotlin-playground-friendly #380

Open
fzhinkin opened this issue Sep 4, 2024 · 2 comments
Open

Tidy up samples to make them more kotlin-playground-friendly #380

fzhinkin opened this issue Sep 4, 2024 · 2 comments
Labels

Comments

@fzhinkin
Copy link
Collaborator

fzhinkin commented Sep 4, 2024

kotlinx-io was recently added to Kotlin Playground.

Some samples could not be executed there directly due to missing imports.
Others, when executed, prints nothing (as they only have asserts). Perhaps, we should follow a path taken by Kotlin Stdlib and replace asserts with print statements in rendered samples.

@fzhinkin fzhinkin added the doc label Sep 4, 2024
@fzhinkin
Copy link
Collaborator Author

fzhinkin commented Sep 4, 2024

Imports will be fixed here: #382

@fzhinkin
Copy link
Collaborator Author

fzhinkin commented Sep 6, 2024

Some samples use unsigned integer types to represent internal state (CRC32, for example), which contradicts guidelines on how these types should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant