-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ktabs): allow tab anchors to be links [KHCP-13866] #2532
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/components/tabs.md
Outdated
## Usage | ||
|
||
### Tab links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the new "Usage" section here -- can we just document "Tabs as Links" under the Props instead (above the Slots section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Made it a subheading under tabs
prop since it mostly relates to that prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [9.14.18](v9.14.17...v9.14.18) (2024-12-03) ### Bug Fixes * **ktabs:** allow tab anchors to be links [KHCP-13866] ([#2532](#2532)) ([cdf5caa](cdf5caa))
🎉 This PR is included in version 9.14.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13866
Add
to
property inTab
interface to support rendering tabs as links