Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kselect): item creation logic [KHCP-13908] #2512

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 12, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-13908

Update KSelect item creation logic to allow creating an item for any unique string rather than only when search produces no results.

@portikM portikM self-assigned this Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 8debca7
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67338ff1d222a2000872a461
😎 Deploy Preview https://deploy-preview-2512--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 8debca7
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67338ff1e370a100081a7b7f
😎 Deploy Preview https://deploy-preview-2512--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review November 12, 2024 17:30
@portikM portikM enabled auto-merge (squash) November 12, 2024 17:30
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@portikM portikM merged commit 03611ce into main Nov 12, 2024
11 checks passed
@portikM portikM deleted the fix/khcp-13908-kselect-item-creation-logic branch November 12, 2024 22:36
kongponents-bot pushed a commit that referenced this pull request Nov 12, 2024
## [9.14.11](v9.14.10...v9.14.11) (2024-11-12)

### Bug Fixes

* **kselect:** item creation logic [KHCP-13908] ([#2512](#2512)) ([03611ce](03611ce))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants