-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kcopy): reskin component [KHCP-9663] #1925
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c184e53
chore(sandbox): setup component sandbox [KHCP-9663]
portikM 3df4437
feat(kcopy): reskin component [KHCP-9663]
portikM 591591d
fix(kcard): add comment [KHCP-9663]
portikM 0f93314
chore(kcopy): sandbox tweaks [KHCP-9663]
portikM 710c2a8
fix(kcopy): address PR feedback [KHCP-9663]
portikM 566713a
fix(kcopy): address PR feedback [KHCP-9663]
portikM d69a715
fix(kcopy): address Pr feedback [KHCP-9663]
portikM e20c813
fix(kcopy): address PR feedback [KHCP-9663]
portikM f8fc61c
fix(kcopy): minor tweak [KHCP-9663]
portikM d638c3f
chore(sandbox): minor fix [KHCP-9663]
portikM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| <template> | ||
| <SandboxLayout | ||
| :links="inject('app-links', [])" | ||
| title="KCopy" | ||
| > | ||
| <div class="kcopy-sandbox"> | ||
| <!-- Props --> | ||
| <SandboxTitleComponent | ||
| is-subtitle | ||
| title="Props" | ||
| /> | ||
| <SandboxSectionComponent title="text"> | ||
| <KCopy :text="uuid1" /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="badge"> | ||
| <KCopy | ||
| badge | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="badgeLabel"> | ||
| <KCopy | ||
| badge | ||
| badge-label="Id:" | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="truncate"> | ||
| <KCopy | ||
| :text="uuid1" | ||
| truncate | ||
| /> | ||
| <KCopy | ||
| badge | ||
| :text="uuid1" | ||
| truncate | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="truncationLimit"> | ||
| <KCopy | ||
| :text="uuid1" | ||
| truncate | ||
| :truncation-limit="5" | ||
| /> | ||
| <KCopy | ||
| badge | ||
| :text="uuid1" | ||
| truncate | ||
| :truncation-limit="5" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="copyTooltip"> | ||
| <KCopy | ||
| copy-tooltip="Click to copy successfully" | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="textTooltip"> | ||
| <KCopy | ||
| :text="uuid1" | ||
| text-tooltip="Text hover tooltip" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="successTooltip"> | ||
| <KCopy | ||
| success-tooltip="Successfully copied" | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="monospace"> | ||
| <KCopy | ||
| :monospace="false" | ||
| :text="uuid1" | ||
| /> | ||
| <KCopy | ||
| badge | ||
| monospace | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| <SandboxSectionComponent title="format"> | ||
| <KCopy :text="uuid1" /> | ||
| <KCopy | ||
| format="hidden" | ||
| :text="uuid1" | ||
| /> | ||
| <KCopy | ||
| format="redacted" | ||
| :text="uuid1" | ||
| /> | ||
| <KCopy | ||
| format="deleted" | ||
| :text="uuid1" | ||
| /> | ||
| </SandboxSectionComponent> | ||
| </div> | ||
| </SandboxLayout> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { inject } from 'vue' | ||
| import SandboxTitleComponent from '../components/SandboxTitleComponent.vue' | ||
| import SandboxSectionComponent from '../components/SandboxSectionComponent.vue' | ||
|
|
||
| const uuid1: string = '2cf64827-6c70-4116-906b-4c9aae83fc4a' | ||
| </script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the badge is monospace, it looks like a font weight of
600is being applied; I don't think it should beThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then on the sandbox it looks regular and the other badges look bold. Something is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Badge are supposed to be bold (to match the KBadge styles) but I agree that monospaced ones don't. Fixed now.