From f52d22fac98b09f0d2829e619a5b48baf1e9ed13 Mon Sep 17 00:00:00 2001 From: Philipp Rudloff Date: Thu, 7 Dec 2023 13:04:26 +0100 Subject: [PATCH 1/3] fix(kcopy): icon having left margin when format is hidden MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix an issue when using KCopy’s `props.format` being set to `'hidden'` that adds an unnecessary left margin to the icon even though no text is shown. Signed-off-by: Philipp Rudloff --- src/components/KCopy/KCopy.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/KCopy/KCopy.vue b/src/components/KCopy/KCopy.vue index 952334daa9..8a290e043c 100644 --- a/src/components/KCopy/KCopy.vue +++ b/src/components/KCopy/KCopy.vue @@ -202,7 +202,6 @@ const copyIdToClipboard = (executeCopy: (prop: string) => boolean) => { .truncate-content { display: inline-block; - margin-right: var(--kui-space-30, $kui-space-30); overflow: hidden; text-overflow: ellipsis; white-space: nowrap; @@ -224,6 +223,7 @@ const copyIdToClipboard = (executeCopy: (prop: string) => boolean) => { cursor: pointer; display: flex; font-size: var(--kui-font-size-20, $kui-font-size-20); + gap: var(--kui-space-30, $kui-space-30); line-height: var(--kui-line-height-20, $kui-line-height-20); padding: var(--kui-space-10, $kui-space-10) var(--kui-space-30, $kui-space-30); white-space: nowrap; @@ -237,7 +237,6 @@ const copyIdToClipboard = (executeCopy: (prop: string) => boolean) => { align-items: center; cursor: pointer; display: flex; - margin-left: var(--kui-space-30, $kui-space-30); } .text-icon { From 466ba91701f927cedaa4a6004ec6777f996ba210 Mon Sep 17 00:00:00 2001 From: Philipp Rudloff Date: Thu, 7 Dec 2023 14:43:12 +0100 Subject: [PATCH 2/3] chore(KCopy): remove unused styles Signed-off-by: Philipp Rudloff --- src/components/KCopy/KCopy.vue | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/components/KCopy/KCopy.vue b/src/components/KCopy/KCopy.vue index 8a290e043c..b98967eb62 100644 --- a/src/components/KCopy/KCopy.vue +++ b/src/components/KCopy/KCopy.vue @@ -187,10 +187,6 @@ const copyIdToClipboard = (executeCopy: (prop: string) => boolean) => { align-items: center; display: flex; - &-badge-text { - margin-right: var(--kui-space-40, $kui-space-40); - } - .copy-element { align-items: center; display: inline-flex; From 6cebdedbac4620d02c4f91203757d04a72bd0629 Mon Sep 17 00:00:00 2001 From: Philipp Rudloff Date: Thu, 7 Dec 2023 14:45:00 +0100 Subject: [PATCH 3/3] =?UTF-8?q?fix(KCopy):=20rendering=20badgeLabel=20cont?= =?UTF-8?q?ent=20when=20badgeLabel=20isn=E2=80=99t=20set?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Philipp Rudloff --- src/components/KCopy/KCopy.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/KCopy/KCopy.vue b/src/components/KCopy/KCopy.vue index b98967eb62..011d16519f 100644 --- a/src/components/KCopy/KCopy.vue +++ b/src/components/KCopy/KCopy.vue @@ -1,7 +1,7 @@