fix(datetimepicker): invalid value passed to formatTime [MA-2131] #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-peteu
requested review from
kongponents-bot,
adamdehaven,
jillztom,
kaiarrowood,
a team,
portikM and
ValeryG
as code owners
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mihai-peteu
force-pushed
the
fix/ma-2131-invalid-value-formatTime
branch
from
94d4d88 to
108e04a
Compare
mihai-peteu
commented
Dec 1, 2023
mihai-peteu
commented
Dec 1, 2023
mihai-peteu
commented
Dec 1, 2023
mihai-peteu
commented
Dec 4, 2023
filipgutica
previously approved these changes
Dec 4, 2023
filipgutica
previously approved these changes
Dec 5, 2023
adamdehaven
reviewed
Dec 6, 2023
|
@adamdehaven cleaned up the markdown file, no more mention of |
adamdehaven
approved these changes
Dec 6, 2023
kongponents-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
# [9.0.0-alpha.70](v9.0.0-alpha.69...v9.0.0-alpha.70) (2023-12-06) ### Bug Fixes * **datetimepicker:** invalid value passed to formatTime [MA-2131] ([#1881](#1881)) ([6dde6a5](6dde6a5))
|
🎉 This PR is included in version 9.0.0-alpha.70 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-2131
Error was occurring whenever the consuming app was passing in an invalid time range such as
This was not an issue for relative time frames, only the custom calendar range. We now default that time range's
startandendvalues to today's date, and we avoid passing a null value toformatDisplayDate(), which callsdate-fns-tz'sformatTimefunction under the hoodChanges, hiding whitespace (easier to review):
https://github.com/Kong/kongponents/pull/1881/files?w=1
Sandbox preview:
https://deploy-preview-1881--kongponents.netlify.app/components/datetime-picker.html
PR Checklist