Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do the less check on smart collections #2275

Conversation

chazlarson
Copy link
Contributor

@chazlarson chazlarson commented Oct 16, 2024

Description

Add a setting to control whether less applies to smart collections
Default collection count for comparison to 0 if the count is None

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Updated Documentation to reflect changes
  • Updated the CHANGELOG with the changes

@chazlarson chazlarson changed the base branch from master to nightly October 16, 2024 21:41
@YozoraXCII
Copy link
Contributor

YozoraXCII commented Oct 17, 2024

I see that .envrc is added, is that intentional here?

Also can't merge because of a conflict in changelog

…ion-when-evaluating-delete-if-less-condition
@chazlarson
Copy link
Contributor Author

I see that .envrc is added, is that intentional here?

Yeah, for those who use direnv

Also can't merge because of a conflict in changelog

Fixed.

@meisnate12 meisnate12 merged commit 1ae229e into nightly Oct 23, 2024
4 checks passed
@meisnate12 meisnate12 deleted the 2274-empty-smart-collections-cause-exception-when-evaluating-delete-if-less-condition branch October 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty smart collections cause exception when evaluating delete if less condition
3 participants