Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator ? #6

Open
chandu0101 opened this issue Oct 3, 2015 · 4 comments
Open

navigator ? #6

chandu0101 opened this issue Oct 3, 2015 · 4 comments

Comments

@chandu0101
Copy link
Contributor

web version of react-navigator - https://github.com/bh5-js/react-navigator

can we add this as dependency and expose via react-native-for-web ?

or can we copy the source to navigator folder( ofc if author of bh-react-navigator agree only) ?

WDYT ..

btw in past you told me that you have something called router built on top navigator ,any plans to include that aswell ?

@mattiamanzati
Copy link
Contributor

The problem with that navigator is that it uses

internally instead of allowing which component to use. In particular I would use instead of
, which does more that a simple
.
https://github.com/bh5-js/react-navigator/blob/master/src/navigator.js#L439

The router I used in the past I deprecated it in favour of redux-router, which now plays well also on RN, but I will consider update and merge it into the repo!

@respectTheCode
Copy link
Contributor

An example of how you used redux-router would be very helpful.

@mattiamanzati
Copy link
Contributor

There is nothing special to do to use it, you can use react-router as in a normal application, just mount memory history instead of location based one :)

@respectTheCode
Copy link
Contributor

An example would still be helpful. There is a lot of information out there saying that react-router does not work with react-native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants