Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using css-layout #17

Open
respectTheCode opened this issue Nov 12, 2015 · 4 comments
Open

Consider using css-layout #17

respectTheCode opened this issue Nov 12, 2015 · 4 comments

Comments

@respectTheCode
Copy link
Contributor

We should consider using css-layout and/or vendor prefixes to get the same layout rendering as react-native.

https://github.com/facebook/css-layout

@mattiamanzati
Copy link
Contributor

Long time ago I considered to write this library as a custom renderer for react instead of writing some sort of html polyfills (and maybe I will reconsider that) and decided that using css-layout will involve extra cost for mobile devices in computation.

Anyway flexbox should be supported by almost 85% of the market, and vendor prefixes are already provided. (I tested it in IE10 mobile, and if it works in IE... almost anywhere! ahaha)

@respectTheCode
Copy link
Contributor Author

I am having layout issues in Safari and it looked like flexbox was the problem. I will dig into this more.

@mattiamanzati
Copy link
Contributor

Thanks for all your support about this project! Let me know any progress!

@respectTheCode
Copy link
Contributor Author

Looks like a safari does things differently when mixing flexbox with minWidth. I restructured things and it is working now.

It would be very interesting to run the css-layout tests against other browsers. Facebook only tests it against Chrome. Those results would tell us if we need to consider css-layout or not.

It looks like about 2% of the traffic to the site I am replacing is on IE 9 or older. I will see what my client says but I may be experimenting with a polyfill.

@respectTheCode respectTheCode changed the title Flexbox doesn't work in most browsers Consider using css-layout Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants