Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No node types beyond NamedThing #58

Closed
caufieldjh opened this issue Jul 7, 2022 · 6 comments
Closed

No node types beyond NamedThing #58

caufieldjh opened this issue Jul 7, 2022 · 6 comments

Comments

@caufieldjh
Copy link
Contributor

We really would like to have Biolink node categories in KG-Phenio, but right now even the types KGX is capable of assigning categories to aren't getting them:

~/kg-phenio/data/merged$ grep MONDO: merged-kg_nodes.tsv | cut -f 2 | sort | uniq
biolink:NamedThing

So there should be some categories for nodes.

Barring KGX assignment, these can be mapped by prefix.

@matentzn
Copy link

matentzn commented Jul 8, 2022

FYI in the old monarch ontology, we merged the biolink model itself into phenio and ran a custom sparql query:

https://github.com/monarch-initiative/monarch-ontology/blob/master/Makefile#L88

Not sure this should be the strategy moving forward.

@caufieldjh
Copy link
Contributor Author

I see some pros and cons to that approach - it would be consistent with the other preprocessing steps to include biolink categories in phenio, but this leaves it unclear which version of the model is being used. The potential to use a modified Monarch-specific version of the model has also come up more than once, so ideally we should have a process in which the desired model version is just specified and applied (and perhaps this is more efficiently done over the graph rather than the OWL).

We see similar issues with KG-OBO: Knowledge-Graph-Hub/kg-obo#111

@matentzn
Copy link

matentzn commented Jul 8, 2022

Maybe the best way is to manually curate top level mappings in an sssom file (bl:phenotype exactMatch UPHENO:123) merge that into phenio and then propagate the bl categories using sparql update dynamically..

@caufieldjh
Copy link
Contributor Author

So the current plan is to attack this on multiple fronts:

@matentzn
Copy link

This sounds perfect to my ears as well!

@caufieldjh
Copy link
Contributor Author

Fixed in build 20220930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants