Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pebble/Jade/Thymeleaf/Rocker/Freemaker template engines support #20

Open
tomaszmichalak opened this issue Dec 17, 2019 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@tomaszmichalak
Copy link
Member

tomaszmichalak commented Dec 17, 2019

Is your feature request related to a problem? Please describe.
Knot.x Template Engine supports Handlebars syntax. Other engines can be utilised:

  • Freemarker
  • Jade
  • mvel
  • Pebble
  • Rocker
  • Thymeleaf

Describe the solution you'd like
Use Vert.x modules inside Knot.x Template Engine: https://github.com/vert-x3/vertx-web/tree/master/vertx-template-engines.

@pun-ky
Copy link

pun-ky commented Dec 17, 2019

handlebars templates are very strict but this strictness very often makes integration/implementation costs much bigger.. e.g no ability to set tmp variable in handlebars is very annoying and this causes very often a need for creating custom handlebars helper. using e.g pebble with better performance and more features could help a lot in delivering knotx based integrations faster.

@tomaszmichalak tomaszmichalak added the enhancement New feature or request label Jan 2, 2020
@marcinus
Copy link
Contributor

Vert.x modules have a direct caching and filesystem integration - this may not be desired as it will not be configurable

@marcinus
Copy link
Contributor

Freemarker, Peeble, Thymeleaf, MVEL can be integrated without any significant changes.
Jade will require creating a custom TemplateLoader, but it should not be a problem.
Rocker is problematic - it's engine has filesystem callsand I have not found any workaround so far.

marcinus added a commit to marcinus/knotx-template-engine that referenced this issue Jan 21, 2020
marcinus added a commit to marcinus/knotx-template-engine that referenced this issue Jan 21, 2020
@marcinus marcinus mentioned this issue Jan 24, 2020
6 tasks
marcinus added a commit that referenced this issue Jan 28, 2020
marcinus pushed a commit to Knotx/knotx-stack that referenced this issue Jan 30, 2020
marcinus added a commit that referenced this issue Jan 30, 2020
marcinus added a commit that referenced this issue Feb 3, 2020
marcinus added a commit that referenced this issue Feb 3, 2020
@pun-ky
Copy link

pun-ky commented Mar 25, 2020

thanks for delivering it <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants