Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jknack handlebars to the latest version and reuse its cache #13

Open
malaskowski opened this issue May 17, 2019 · 1 comment
Open

Update jknack handlebars to the latest version and reuse its cache #13

malaskowski opened this issue May 17, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@malaskowski
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, Knot.x Handlebars TE Strategy uses implementation(group = "com.github.jknack", name= "handlebars", version = "4.0.6").
There is a newer version available.

Describe the solution you'd like
Upgrade handlebars lib to the latest version and reuse its cache instead of existing Guava cache. It would be a good idea to make it configurable.

Describe alternatives you've considered
If it would be impossible to keep the cache config, consider leaving the current one.
@malaskowski malaskowski added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 17, 2019
@malaskowski
Copy link
Member Author

Lib updated to 4.1.2 version in #18 .
Stil cache update is ToDo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malaskowski