New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Una validación mas #4

Open

panswer opened this issue Nov 29, 2022 · 1 comment

panswer commented Nov 29, 2022

clean-course/src/clean-code/05-dry.ts

Line 18 in eb94920

if ( (<number><unknown>this[key]) <= 0 ) throw Error(`${ key } is zero`);

Estuve realizando pruebas y falto validar NaN si llegase a estar como price

mi solucion es:

if (this[key] <= 0 || !this[key]) throw Error(`${key} is zero`);

Author

panswer commented Nov 29, 2022

Excelente curso de clean code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment