Add XP_POWER ISU02 series DC to DC converter symbol. #1116
Conversation
antoniovazquezblanco
added
Pending reviewer
|
What do I need to do to get this pull request to pass the checks? Does the footprint library change need to be merged first? The reason I ask is that I have a few more changes pending and I would like to keep my repos tidy. |
|
The error about missing footprints will only go away if the footprint is merged. However we still prefer the symbol and footprint pull requests to be opened at the same time. (This allows us to check them in one go) We then merge the footprint first and restart the testscript before finally merging the symbol. There is however a second error reported. You need to fill out the footprint filter in addition to the footprint field. This is for both future proofing the symbol and also to allow users to add alternative footprints (example a handsolder version) and find it easily in cvpcb. |
|
Thanks Rene. I missed the footprint filter issue. I just pushed the fix for this. Thanks! |
|
Here is the datasheet link that I forgot to attach. |
|
What's left to get this merged? It looks like everything is good to go or am I missing something. |
|
Someone should manually go over it and perform a quality review in depth. No one is assigned yet to your PR. |
|
Remove one of the dashed isolation lines per request. Remove "regulated" from description field. Change pin names with +/- as a suffix to prefix. Add single channel symbol and aliases.
|
I just pushed the changes requested below including adding the single
output variants. Please let me know if there are any other issues.
…On 11/13/2018 11:26 AM, evanshultz wrote:
* The pin names for pins 1, 6, 7, and 14 should have the "+" or "-" at
the front of the pin name.
* From KiCad/kicad-website#284
<KiCad/kicad-website#284>, can you change
the double dashed line to a single one?
* Please remove "regulated" from the description. This is implied and
I don't see it used elsewhere (I so see "fixed" but it could be
removed too).
* Lastly, note for the future that this symbol is only for the Dual
output version. I'd obviously rather have you writing or reviewing
code for KiCad, so I won't ask you to add the Single output symbol.
But if you already have it that would flesh out this series.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1116 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFnmpoNbx6PdjQ39YkXfs-e31Zd5tGwFks5uuvLDgaJpZM4YL5KB>.
|
|
It's easier on the librarian team if any new or notably changed symbols are added as screenshots.
|
Change negative output pin to be in same location as common pin for dual converters. Make no connection pins zero length and move them to the body edge to prevent inadvertent connections. Minor description error fixes.
|
I made the changes you requested.
The pin layout changes make for a rather ugly (asymmetrical) symbol but
I see your point about dropping in a single for a dual without changing
the schematic wiring.
…On 11/13/2018 2:40 PM, evanshultz wrote:
It's easier on the librarian team if any new or notably changed symbols
are added as screenshots.
image
<https://user-images.githubusercontent.com/1936989/48438447-e5f78e00-e77b-11e8-99de-2553658d2644.png>
* ISU0205S05, ISU0224S15, ISU0224S24, and all ISU0248Sxx are missing
the word "Module" in the description.
* ISU0205S15 says 12V in the description but it should be 15V.
* I'd like to see the single-channel put -VOUT where COM is on the
dual-channel since that would make changing from single to dual
easier. I'm not sure if that's common, but it would require the
least amount of changes if going between them.
* The symbol's datasheet field (F3) should be empty.
* Please push the end of the NC pins to the edge of the body for the
single output version so the NC pins are unlikely to connect to
anything.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1116 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFnmpmn9U9C5fbPIRZN526YtO1K7_lljks5uuyA_gaJpZM4YL5KB>.
|
|
Thanks! I just have one more comment: http://kicad-pcb.org/libraries/klc/S4.1/ states pins should be 100mil for this symbol, and there's no clause about NC pin length. Their length is 0mil here and we've always used 100mil even for NC pins. For consistency, at least until we can figure out if NC pins can be handled differently, can you length them? Keep their end where it is but lengthen the pin inside the symbol body. |
|
Your killing me! ;) I shouldn't have assumed that the NC pins were zero
length. It just made sense to me. I've pushed change.
…On 11/14/2018 11:31 AM, evanshultz wrote:
Thanks!
I just have one more comment: http://kicad-pcb.org/libraries/klc/S4.1/
states pins should be 100mil for this symbol, and there's no clause
about NC pin length. Their length is 0mil here and we've always used
100mil even for NC pins. For consistency, at least until we can figure
out if NC pins can be handled differently, can you length them? Keep
their end where it is but lengthen the pin inside the symbol body.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1116 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFnmpkbXvFUCrTKScQyhckrM6CvZTUGpks5uvEVlgaJpZM4YL5KB>.
|
|
Don't capitulate yet! Thank you. This looks good and I hope you're willing to submit more PRs. :) |
I've added the XP Power ISU02 series DC to DC converter symbol to the DC to DC convert library. The footprint pull request is coming shortly. Unfortunately, the 3D model code for DC to DC converters doesn't really have nice gull-wing leads (at least that I was willing to spend the time on) so I didn't make a 3D model.
Here is the footprint pull request KiCad/kicad-footprints#1065.
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: