Skip to content

Commit

Permalink
Merge branch 'master' into app-component
Browse files Browse the repository at this point in the history
  • Loading branch information
Amzani authored Nov 2, 2023
2 parents 9e37b30 + a81e35b commit 0d06f42
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@

# The default owners are automatically added as reviewers when you open a pull request unless different owners are specified in the file.

* @fmvilas @boyney123 @mcturco @magicmatatjahu @KhudaDad414 @asyncapi-bot-eve
* @fmvilas @boyney123 @mcturco @magicmatatjahu @KhudaDad414 @Amzani @asyncapi-bot-eve
2 changes: 1 addition & 1 deletion apps/studio/src/examples/tutorials/invalid.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This invalid file exists solely for educational purposes, and if you come across it, here is the tutorial: https://www.asyncapi.com/docs/tutorials/validate-documents
# This invalid file exists solely for educational purposes, and if you come across it, here is the tutorial: https://www.asyncapi.com/docs/tutorials/studio-document-validation

asyncapi: '1.0.0'
info:
Expand Down
24 changes: 24 additions & 0 deletions doc/adr/0005-use-tailwind-in-design-system.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# 5. Integrate Tailwind CSS into Design System for Styling

Date: 2023-10-24

## Status

Accepted

## Context

As of now, the design system doesn't provide a way to style components.
All of the styling has to be done in the `ui` package. why do we want to styling in design system?
Well, if we want to showcase how [Organisms](https://atomicdesign.bradfrost.com/chapter-2/#organisms) like Forms behave we need some basic styling support in design system as well.
The studio is already planning to use Tailwind CSS for its UI, making it a logical choice to consider Tailwind for the design system as well.

## Decision

We propose to integrate Tailwind CSS into our design system. This will allow us to use the tailwind utility classes in our design system as well, such as Forms.

## Consequences

- Tailwind utility classes will be usable in design system.
- Another tool (`concurently`) have to be used to run storybook and tailwind css side by side.
- design system will be more complex and harder to understand for newcomers.

0 comments on commit 0d06f42

Please sign in to comment.