-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan Loader settings log inconsistency #1594
Comments
Yep, this is an oversight in the implementation. When the loader settings file doesn't have a stderr_log field, the "debug_level" is left at the default zero value. Buuut when logging the loader would not bother checking VK_LOADER_DEBUG at all if the settings file was active, irregardless of the settings. It is a simple one line fix to make the log function require that the settings file debug level is 'non-zero' (set to something) before using that as the filter. (and the fix will be pushed up in the extended_loader_settings_tests branch shortly) |
I do think it may be beneficial to have the log messages be filtered by the union of the VK_LOADER_DEBUG and loader settings file stderr_log output. The current logic means that a user who opened vkconfig & set some filters may not know that those filters are what will be used. They then may try to set VK_LOADER_DEBUG and see no change in behavior. This is more of an edge case & learning curve than a pure problem. But I raise it to get your opinion. |
I think this is plently already, no need to have a union mode specifcally because I don't think "The current logic means that a user who opened vkconfig & set some filters may not know that those filters are what will be used. They then may try to set And a union would imply that if If you add something that enables to switch between both mode in vk_loader_settings.json, then why not, |
This issue still reproduce with today build of Vulkan Loader main branch |
I would expect to be able to control logging with
VK_LOADER_DEBUG=all
when not using thestderr_log
section invk_loader_settings.json
, a bit like I can control layers withVK_LOADER_LAYERS_ENABLE
when there are not invk_loader_settings.json
.However, when using the Vulkan Loader settings WITHOUT "stderr_log" section but using
VK_LOADER_DEBUG=all
I am getting the following log which is pretty short:vk_loader_settings.json
vk_loader_settings.json
When using
stderr_log
with all the log type I am getting a very exhautive log:The text was updated successfully, but these errors were encountered: