-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sycl_khr_group_interface extension #638
base: main
Are you sure you want to change the base?
Conversation
This extension introduces an alternative interface for groups of work-items, offering several improvements over the SYCL 2020 interface: - Shorter names for member functions, dropping the get_ prefix. - Cleaner separation between properties of a group (e.g., a group id) and properties of the calling work-item (e.g., its id within a group). - Clearer distinction between "group" concept and "work_group" class. - New work_item class to represent a single work-item within a specific parent group. This class also satisfies the group concept, modeling a group containing a single work-item.
dc92d73
to
93e784e
Compare
khr::work_item is not templated on dimensions.
The synopsis previously assumed that the extents would be one dimensional, but it must match the ParentGroup. There is no suitable shorthand alias or exposition-only description for this case defined by mdspan, so replace the type with a comment.
I like the usage of namespace.
Few questions (sorry, trying to understand this new khr mechanism), should it be :
|
I don't think so. When vendors introduce extensions they use The way I see it, although putting something in the |
This extension introduces an alternative interface for groups of work-items, offering several improvements over the SYCL 2020 interface:
Shorter names for member functions, dropping the get_ prefix.
Cleaner separation between properties of a group (e.g., a group id) and properties of the calling work-item (e.g., its id within a group).
Clearer distinction between "group" concept and "work_group" class.
New work_item class to represent a single work-item within a specific parent group. This class also satisfies the group concept, modeling a group containing a single work-item.