Increase math builtin test fragment size #975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CI for the SYCL CTS is failing for DPC++ due to a timeout. This commit attempts to find a sweet-spot for the fragmentation size of math builtin test, balancing compilation resources and compilation time. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
commented
Oct 30, 2024
steffenlarsen
commented
Oct 30, 2024
|
What does that CMake option do? |
The option is for controlling the number of math builtin test permutations being put into the same source-file. The intention is to find the sweet-spot for parallelizing the compilation. I would like to see this be a top-level option when configuring the CTS eventually, but for now the intention is to try and avoid the CI timing out. |
keryell
reviewed
Nov 23, 2024
| @@ -44,7 +44,7 @@ foreach(cat ${MATH_CAT}) | |||
| FILE_PREFIX "math_builtin_${cat}" | |||
| EXT "cpp" | |||
| INPUT "math_builtin.template" | |||
| EXTRA_ARGS -test ${cat} -marray true -fragment-size 150 | |||
| EXTRA_ARGS -test ${cat} -marray true -fragment-size 230 | |||
There was a problem hiding this comment.
While you are here, you could factorized out this function or macro and add your PR comment as a code comment. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CI for the SYCL CTS is failing for DPC++ due to a timeout. This commit attempts to find a sweet-spot for the fragmentation size of math builtin test, balancing compilation resources and compilation time.