Gather linker flags to prevent /link break linking stage #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fail because the job reaches timelimit. |
jiezzhang
force-pushed
the
jiezzhang/fix-win-linker-issue
branch
from
0926350
to
7d11d59
Compare
|
WG approves to merge. Implementation specific fix for link flags. |
bader
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DCMAKE_EXE_LINKER_FLAGS="/link /stack:2097152"will break linking stage on Windows because all options following "/link" are passed to linker. And "-o" passed to linker can't be recognized by linker and trigger an error