Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec change] Add sycl_khr_group_interface extension #957

Open
sycl-issue-bot bot opened this issue Oct 4, 2024 · 1 comment
Open

[Spec change] Add sycl_khr_group_interface extension #957

sycl-issue-bot bot opened this issue Oct 4, 2024 · 1 comment

Comments

@sycl-issue-bot
Copy link

sycl-issue-bot bot commented Oct 4, 2024

Please review whether KhronosGroup/SYCL-Docs#638 by @Pennycook requires any changes to the CTS.

If changes are required: Open a new PR addressing the changes and link it to this issue.
If no changes are required: Close this issue and proceed with the spec PR.

@Pennycook
Copy link
Contributor

The CTS will require additional tests:

  • Check the types of all the members defined in khr::work_group, khr::sub_group and khr::work_item.
  • Call the member functions of khr::work_group, khr::sub_group and khr::work_item.
  • Call get_item() for various group types and check the return type.
  • Call leader_of() for various group types and check the return value.

One thing that isn't clear to me is exactly how we want to define the expected values of these tests. For the DPC++ implementation of the prototype, I compared against functionality that is already tested elsewhere (e.g., the value returned by khr::work_group::id() is checked against the value returned by group::get_group_id()), but the CTS could instead choose to compare with specific expected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant