Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT for enqueueMarkerWithWaitList #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

UT for enqueueMarkerWithWaitList #257

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
420ee01
UT for enqueueMarkerWithWaitList
piotr-wozniak-mobica Aug 18, 2023
63d8b8f
Changed event list
kamil-goras-mobica Nov 16, 2023
a45e6a8
Merge branch 'main' into ut_enqueueMarkerWithWaitList
kamil-goras-mobica Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions tests/test_openclhpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4517,4 +4517,35 @@ void testgetObjectInfo() {
TEST_ASSERT_EQUAL(type, CL_GL_OBJECT_BUFFER);
TEST_ASSERT_EQUAL(bufobj, 0);
}
#if CL_HPP_TARGET_OPENCL_VERSION >= 120
static cl_int clEnqueueMarkerWithWaitList_testenqueueMarkerWithWaitList(
cl_command_queue command_queue, cl_uint num_events_in_wait_list,
const cl_event *event_wait_list, cl_event *event, int num_calls) {
TEST_ASSERT_EQUAL_PTR(make_command_queue(0), command_queue);
TEST_ASSERT_EQUAL(1, num_events_in_wait_list);
TEST_ASSERT_NOT_NULL(event_wait_list);
TEST_ASSERT_EQUAL(0, num_calls);
if (event != nullptr) {
*event = make_event(1);
}
return CL_SUCCESS;
}

void testenqueueMarkerWithWaitList() {
cl_int ret = CL_DEVICE_NOT_FOUND;
cl::Event event;
cl::vector<cl::Event> events = {event};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid "real-world" code - the set of events in the event wait list must be different than the event that is signaled. Coudl you please make a specific event to wait upon instead? This would also allow us to ensure that it was passed through correctly.

Something like:

Suggested change
cl::Event event;
cl::vector<cl::Event> events = {event};
cl::Event event;
cl::vector<cl::Event> events = {cl::Event(make_event(0))};


clEnqueueMarkerWithWaitList_StubWithCallback(
clEnqueueMarkerWithWaitList_testenqueueMarkerWithWaitList);
ret = commandQueuePool[0].enqueueMarkerWithWaitList(&events, &event);
TEST_ASSERT_EQUAL(CL_SUCCESS, ret);
TEST_ASSERT_EQUAL_PTR(make_event(1), event());

event() = nullptr;
events[0]() = nullptr;
}
#else
void testenqueueMarkerWithWaitList() {}
#endif // CL_HPP_TARGET_OPENCL_VERSION >= 120
} // extern "C"