Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT for createSubBuffer #254

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

UT for createSubBuffer #254

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41289ab
UT for createSubBuffer
piotr-wozniak-mobica Aug 7, 2023
32e27e8
Added review corrections
kamil-goras-mobica Nov 16, 2023
f341bfb
Merge branch 'main' into ut_createSubBuffer
kamil-goras-mobica Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions tests/test_openclhpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4517,4 +4517,37 @@ void testgetObjectInfo() {
TEST_ASSERT_EQUAL(type, CL_GL_OBJECT_BUFFER);
TEST_ASSERT_EQUAL(bufobj, 0);
}
#if CL_HPP_TARGET_OPENCL_VERSION >= 110
static cl_mem clCreateSubBuffer_testCreateSubBuffer(
cl_mem buffer, cl_mem_flags flags, cl_buffer_create_type buffer_create_type,
const void *buffer_create_info, cl_int *errcode_ret, int num_calls) {
(void)errcode_ret;
TEST_ASSERT_EQUAL(make_mem(0), buffer);
TEST_ASSERT_EQUAL(0, flags);
TEST_ASSERT_EQUAL(0, buffer_create_type);
TEST_ASSERT_EQUAL_PTR(nullptr, buffer_create_info);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to be testing more real-world values here:

  • buffer - this one is OK.
  • flags - a value of 0 is legal, but it's not a very useful value to test to see if the flags are being passed through properly. Maybe pass something like CL_MEM_READ_ONLY instead?
  • buffer_create_type - this should be CL_BUFFER_CREATE_TYPE_REGION, since this is the only buffer creation type described in the spec.
  • buffer_create_info - this should be a non-NULL pointer to a cl_buffer_region structure. Ideally, we should check that the pointer is non-NULL, and that the contents of the structure are what we expect.

TEST_ASSERT_EQUAL(0, num_calls);

return make_mem(1);
}

void testCreateSubBuffer() {
#ifndef CL_HPP_ENABLE_EXCEPTIONS
cl_mem_flags flags = 0;
cl_buffer_create_type buffer_create_type = 0;
const void *buffer_create_info = nullptr;
cl_int *err = nullptr;
static cl::Buffer ret;

clCreateSubBuffer_StubWithCallback(clCreateSubBuffer_testCreateSubBuffer);
ret = bufferPool[0].createSubBuffer(flags, buffer_create_type,
buffer_create_info, err);

TEST_ASSERT_EQUAL_PTR(make_mem(1), ret());
ret() = nullptr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this variable non-static:

Suggested change
static cl::Buffer ret;
clCreateSubBuffer_StubWithCallback(clCreateSubBuffer_testCreateSubBuffer);
ret = bufferPool[0].createSubBuffer(flags, buffer_create_type,
buffer_create_info, err);
TEST_ASSERT_EQUAL_PTR(make_mem(1), ret());
ret() = nullptr;
clCreateSubBuffer_StubWithCallback(clCreateSubBuffer_testCreateSubBuffer);
clReleaseMemObject_ExpectAndReturn(make_mem(1), CL_SUCCESS);
cl::Buffer ret = bufferPool[0].createSubBuffer(flags, buffer_create_type,
buffer_create_info, err);
TEST_ASSERT_EQUAL_PTR(make_mem(1), ret());

#endif
}
#else
void testCreateSubBuffer() {}
#endif // CL_HPP_TARGET_OPENCL_VERSION >= 110
} // extern "C"