fix nested Config.array (Effect-TS#3499)

KhraksMamtsov · Aug 23, 2024 · 46a575f · 46a575f
1 parent f960bf4
commit 46a575f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/.changeset/tricky-mails-confess.md b/.changeset/tricky-mails-confess.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+fix nested Config.array, by ensuring path patches aren't applied twice in sequences
diff --git a/packages/effect/src/internal/configProvider.ts b/packages/effect/src/internal/configProvider.ts
@@ -329,7 +329,7 @@ const fromFlatLoop = <A>(
             core.flatMap((indices) => {
               if (indices.length === 0) {
                 return core.suspend(() =>
-                  core.map(fromFlatLoop(flat, patchedPrefix, op.config, true), Arr.of)
+                  core.map(fromFlatLoop(flat, prefix, op.config, true), Arr.of)
                 ) as unknown as Effect.Effect<Array<A>, ConfigError.ConfigError>
               }
               return pipe(

diff --git a/packages/effect/test/Config.test.ts b/packages/effect/test/Config.test.ts
@@ -557,4 +557,16 @@ describe("Config", () => {
     ))
     assert.strictEqual(result, "value")
   })
+
+  it("array nested", () => {
+    const result = Config.array(Config.number(), "ARRAY").pipe(
+      Effect.withConfigProvider(
+        ConfigProvider.fromMap(new Map([["NESTED.ARRAY", "1,2,3"]])).pipe(
+          ConfigProvider.nested("NESTED")
+        )
+      ),
+      Effect.runSync
+    )
+    assert.deepStrictEqual(result, [1, 2, 3])
+  })
 })