Convert MultiSelect and SingleSelect to functional components #2370
+338
−470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner function since that's where sharedProps is applied
🦋 Changeset detectedLatest commit: e02ada1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1 B (0%) Total Size: 101 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-frrushpoud.chromatic.com/ Chromatic results:
|
beaesguerra
commented
Nov 23, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
PR is a WIP - I'll be reviewing and testing more carefully since these components were a bit more complicated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Convert MultiSelect and SingleSelect to functional components to support the validation work to support LabeledField.
I was trying to add in the validation logic without refactoring too much since we might replace these components with Combobox. It was more complicated to account for different cases so I am refactoring it first to make it easier!
Issue: WB-1782
Test plan:
(would appreciate help with extra testing in case I missed something. These components were a bit more complicated to convert to FC!)