Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WB-1804 Use h2 in ModalHeader #2369

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WB-1804 Use h2 in ModalHeader #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6de3605
WB-1804 Use h2 in ModalHeader
Chalayyy Nov 22, 2024
088686f
Add empty changeset
Chalayyy Nov 22, 2024
9b926c2
Add changeset
Chalayyy Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-moons-prove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/wonder-blocks-modal": patch
---

Use h2 tag in modal header instead of h3
2 changes: 2 additions & 0 deletions .changeset/wet-walls-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
1 change: 1 addition & 0 deletions packages/wonder-blocks-modal/src/components/modal-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default function ModalHeader(props: Props) {
<View style={styles.breadcrumbs}>{breadcrumbs}</View>
)}
<HeadingMedium
tag="h2"
style={styles.title}
id={titleId}
testId={testId && `${testId}-title`}
Expand Down
Loading