-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB-1804 Use h2 in ModalHeader #2369
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9b926c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (ef67538) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2369" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2369 |
Size Change: +8 B (+0.01%) Total Size: 101 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀undefined Chromatic results:
|
Summary:
Per this conversation, we want to update the headers in modals to use
h2
instead of the defaulth3
that comes withHeadingMedium
sIssue: WB-1804, AX-340
Test plan:
yarn test
andyarn jest -u
OnePaneDialog
andModalHeader
haveh2
titles instead ofh3