Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gurmukhi Akhar encoding of letters containing / breaks Mahaan Kosh Tooltip #1770

Open
JapnitS opened this issue Nov 26, 2024 · 0 comments
Open

Comments

@JapnitS
Copy link
Collaborator

JapnitS commented Nov 26, 2024

Describe the bug
When using the Gurmukhi Akhar encoding option (in Settings) , the encoding could contain / or other special characters which can cause unintended side effects.
One such example was seen while using Mahaan Kosh Tooltip on the following word:
image

The Gurmukhi Akhar encoding of the word is is/wpY.
The corresponding request to Mahaan Kosh Endpoint is:
image

This confuses the API call as it considers the is/ part of the path rather than considering it a payload.

To Reproduce
Steps to reproduce the behavior:
0. Set the encoding to "Gurmukhi Akhar"

  1. Go to 'https://www.sikhitothemax.org/hukamnama?date=2024/11/25'
  2. Click on ~20th Pangti (||3||)
  3. Try using the Mahaan Kosh Tooltip
  4. See error

Expected behavior
A mahaanKosh tooltip should be displayed

Screenshots
Slack discussion

Desktop (please complete the following information):

  • n/a

Smartphone (please complete the following information):

  • n/a

Additional context
It is a good opportunity to think about other breaking cases and fix them as part of this bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant