Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add related shabads to angs #1154

Open
ManjotS opened this issue Jul 4, 2020 · 8 comments
Open

add related shabads to angs #1154

ManjotS opened this issue Jul 4, 2020 · 8 comments

Comments

@ManjotS
Copy link
Contributor

ManjotS commented Jul 4, 2020

in ang/page view, show all related shabads for the ang..

we could add an endpoint in sttm api to support this better so theres not 5 calls to the api

@gurjit03
Copy link
Collaborator

gurjit03 commented Jul 9, 2020

@ManjotS veerji, is the API support ready?

@ManjotS
Copy link
Contributor Author

ManjotS commented Jul 9, 2020

not for my second sentence

@ManjotS
Copy link
Contributor Author

ManjotS commented Jul 10, 2020

@tarunsingh5
Copy link
Collaborator

i would deprioritize this given that the scores are based on shabads not angs

@tarunsingh5
Copy link
Collaborator

@saintsoldierx thoughts? - i think we should move this ticket to the api to actually run the algo on angs before we implement

@saintsoldierx
Copy link
Collaborator

I am not really for this tbh. I think if someone is searching by ANG then they aren't really searching for any topic in particular so why would we need related shabads? I am not sure this is a valid use case, but am open to opinion @tarunsingh5 @ManjotS @plug-n-play @tsingh777

@saintsoldierx saintsoldierx self-assigned this Jan 5, 2021
@saintsoldierx
Copy link
Collaborator

@gurjit03 if the api work is done, then it should be easy to add this to ang view?

@gurjit03
Copy link
Collaborator

gurjit03 commented Jun 25, 2024

@saintsoldierx this should be easy indeed but will check the interface.
@ManjotS can you please share what API request we needs to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants