Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring cache files #194

Open
benvanwerkhoven opened this issue Apr 7, 2023 · 2 comments
Open

Refactoring cache files #194

benvanwerkhoven opened this issue Apr 7, 2023 · 2 comments

Comments

@benvanwerkhoven
Copy link
Collaborator

I think it's time to refactor the functionality for cache files. We now run into issues when we try to load a cachefile created half a year ago, because certain timings or other fields are missing. Cache files are also used by multiple tools, such as the dashboard, so it makes sense to properly define them.

In terms of code we could group all related methods into a single object and module, as everything related to cache files is now in util.py.

It would also be good to properly define the format of cachefiles using a JSON schema with a version number and functionality to automatically convert cache files created using earlier versions of Kernel Tuner to newer versions.

@benvanwerkhoven
Copy link
Collaborator Author

I recently spent some time thinking about the interface we have for caches. I thought that if we want to have more options to specify things related to the cache file that we could work with a dict in place of the current string passed to the cache= option of tune_kernel. This dict could then have a key 'name' with the filename and any number of other fields to specify other things.

@isazi
Copy link
Collaborator

isazi commented Oct 31, 2023

Sounds more future proof than just the file name we pass now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants