Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename normalize #404

Open
SergeStinckwich opened this issue Dec 16, 2021 · 1 comment
Open

Rename normalize #404

SergeStinckwich opened this issue Dec 16, 2021 · 1 comment

Comments

@SergeStinckwich
Copy link
Collaborator

SergeStinckwich commented Dec 16, 2021

Like separateExpression, normalize on expression has no precise definition (see #399) ... What does that mean to normalize? Apparently this is to simplify formula by moving substraction at the top ... Like separateExpression, this is only used in generateEvents. We have to rename this method with a meaningful name, see what are the specifing needs in generateEvents in order to have a more formal definition at the end.

@mikalziane
Copy link
Collaborator

mikalziane commented Dec 16, 2021

Normalization is only possible when the considered operators, on the considered domains, have appropriate properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants