Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 close buttons not closing form popup #186

Open
erfg12 opened this issue Jul 8, 2021 · 3 comments
Open

Bootstrap 5 close buttons not closing form popup #186

erfg12 opened this issue Jul 8, 2021 · 3 comments

Comments

@erfg12
Copy link

erfg12 commented Jul 8, 2021

If you want the popups to close in Bootstrap 5, you need to change data-dismiss to data-bs-dismiss. There's 3 instances of this in the src/dataTables.altEditor.free.js file.

@luca-vercelli
Copy link
Collaborator

luca-vercelli commented Jul 8, 2021 via email

@mmmcorpsvit
Copy link

my fix

              var modal = `
                <div class="modal fade" id="${modal_id}" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
                <div class="modal-dialog">
                  <div class="modal-content">
                    <div class="modal-header">
                      <h5 class="modal-title" id="exampleModalLabel">Modal title</h5>
                      <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
                    </div>
                    <div class="modal-body">
                      <p></p>
                    </div>
                    <div class="modal-footer">
                    </div>
                  </div>
                </div>
              </div>`;

fix secondary button style, change:
btn-default button secondary -> btn-secondary

full src: https://www.codepile.net/pile/bQL1JOdN
work in progress... will be nice you help)

@deliciouslytyped
Copy link

@erfg12 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants