Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] support closed shadow DOM #28

Open
1 task done
ghost opened this issue Nov 21, 2024 · 1 comment
Open
1 task done

[Feature request] support closed shadow DOM #28

ghost opened this issue Nov 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Nov 21, 2024 •
edited by kaliiiiiiiiii
Loading

System info

  • Playwright Version: [v1.XX] 1.49
  • Operating System: [All, Windows 11, Ubuntu 20, macOS 13.2, etc.] ubuntu 24.04
  • Browser: [All, Chromium, Firefox, WebKit] chrome
  • Other info:

Source code

  • I provided exact source code that allows reproducing the issue locally.

Repo: fancy45daddy/shadowroot

Script: fancy45daddy/shadowroot/@main/play.mjs

Works with import * as playwright from 'playwright'
but not with import * as playwright from 'patchright'

Expected

the value in iframe input is bebo

Actual

the value in iframe input still placeholder
@kaliiiiiiiiii kaliiiiiiiiii changed the title [BUG] I have a repository https://github.com/fancy45daddy/shadowroot, I can change the value in closed shadowroot in playwright but not in patchright [BUG] changing the value in closed shadowroot fails Nov 21, 2024
@kaliiiiiiiiii kaliiiiiiiiii added bug Something isn't working unconfirmed not reproduced yet labels Nov 21, 2024
@kaliiiiiiiiii kaliiiiiiiiii changed the title [BUG] changing the value in closed shadowroot fails [Feature request] support closed shadow DOM Nov 28, 2024
@kaliiiiiiiiii
Copy link
Collaborator

PW docs: https://playwright.dev/docs/locators#locate-in-shadow-dom

Closed-mode shadow roots are not supported.

Reference for implementation:
https://github.com/kaliiiiiiiiii/Selenium-Driverless/blob/ca333fd88b0b7722ac128e08deccbb5ffbd66b39/src/selenium_driverless/types/webelement.py#L237

@kaliiiiiiiiii kaliiiiiiiiii added enhancement New feature or request and removed bug Something isn't working unconfirmed not reproduced yet labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaliiiiiiiiii